Re: [PATCH] drm/i915/gen9: Add missing 10bpc formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Sent: Monday, November 11, 2019 7:34 PM
> To: Kadiyala, Kishore <kishore.kadiyala@xxxxxxxxx>
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re:  [PATCH] drm/i915/gen9: Add missing 10bpc formats
> 
> On Mon, Nov 11, 2019 at 09:22:41AM +0530, Kishore Kadiyala wrote:
> > Add 10bpc formats for gen9.
> > This patch has dependency on below patch:
> > https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2
> >
> > Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c
> > b/drivers/gpu/drm/i915/display/intel_sprite.c
> > index d7f71fa90659..fad73ea00992 100644
> > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > @@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
> >  	DRM_FORMAT_ABGR8888,
> >  	DRM_FORMAT_XRGB2101010,
> >  	DRM_FORMAT_XBGR2101010,
> > +	DRM_FORMAT_ARGB2101010,
> > +	DRM_FORMAT_ABGR2101010,
> 
> Nope. Alpha blending is not supported with 10bpc formats on pre-icl platforms.

I have checked the capabilities for Gen9 and as you pointed Alpha is not supported for 10bpc formats.
This patch can be dropped.

> 
> >  	DRM_FORMAT_XRGB16161616F,
> >  	DRM_FORMAT_XBGR16161616F,
> >  	DRM_FORMAT_YUYV,
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux