Re: [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20191108]
[cannot apply to v5.4-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Taint-the-kernel-on-dumping-the-GEM-ftrace-buffer/20191109-171107
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-b003-201944 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
                    from drivers/gpu/drm/i915/gt/intel_gt.h:9,
                    from drivers/gpu/drm/i915/selftests/igt_flush_test.c:7:
   drivers/gpu/drm/i915/selftests/igt_flush_test.c: In function 'igt_flush_test':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                 ^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
                    from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
                    from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
                    from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
                    from drivers/gpu/drm/i915/gt/intel_context.c:7:
   drivers/gpu/drm/i915/gt/selftest_context.c: In function '__live_active_context':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                 ^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
                    from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
                    from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
                    from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
                    from drivers/gpu/drm/i915/gt/intel_lrc.c:136:
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_sanitycheck':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                 ^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'slice_semaphore_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:416:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:614:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_busywait_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:794:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:895:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_late_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:1013:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_cancel':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:1485:2: note: in expansion of macro 'GEM_TRACE_DUMP'
     GEM_TRACE_DUMP();
     ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_hang':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:1967:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'nop_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:2476:5: note: in expansion of macro 'GEM_TRACE_DUMP'
        GEM_TRACE_DUMP();
        ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'mask_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_lrc.c:2619:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
                    from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
                    from drivers/gpu/drm/i915/i915_request.h:31,
                    from drivers/gpu/drm/i915/i915_active.h:13,
                    from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
                    from drivers/gpu/drm/i915/i915_drv.h:71,
                    from drivers/gpu/drm/i915/display/intel_display_types.h:46,
                    from drivers/gpu/drm/i915/gt/intel_reset.c:10:
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'active_request_put':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                 ^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
      GEM_TRACE_DUMP();
      ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function '__igt_reset_engines':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c:881:6: note: in expansion of macro 'GEM_TRACE_DUMP'
         GEM_TRACE_DUMP();
         ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'igt_reset_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c:1422:5: note: in expansion of macro 'GEM_TRACE_DUMP'
        GEM_TRACE_DUMP();
        ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
                    from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
                    from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
                    from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
                    from drivers/gpu/drm/i915/i915_request.c:32:
   drivers/gpu/drm/i915/selftests/i915_request.c: In function '__igt_breadcrumbs_smoketest':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                 ^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
     do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
                                                  ^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
       GEM_TRACE_DUMP();
       ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +72 drivers/gpu/drm/i915/i915_gem.h

    64	
    65	#if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
    66	#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
    67	#define GEM_TRACE_ERR(...) do {						\
    68		pr_err(__VA_ARGS__);						\
    69		trace_printk(__VA_ARGS__);					\
    70	} while (0)
    71	#define GEM_TRACE_DUMP() \
  > 72		do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
    73	#define GEM_TRACE_DUMP_ON(expr) \
    74		do { if (expr) GEM_TRACE_DUMP(); } while (0)
    75	#else
    76	#define GEM_TRACE(...) do { } while (0)
    77	#define GEM_TRACE_ERR(...) do { } while (0)
    78	#define GEM_TRACE_DUMP() do { } while (0)
    79	#define GEM_TRACE_DUMP_ON(expr) BUILD_BUG_ON_INVALID(expr)
    80	#endif
    81	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux