Quoting Daniel Vetter (2019-11-08 09:54:42) > On Wed, Nov 6, 2019 at 4:49 PM Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > > > With the goal of removing the serialisation from around execbuf, we will > > no longer have the privilege of there being a single execbuf in flight > > at any time and so will only be able to inspect the user's flags within > > the carefully controlled execbuf context. i915_gem_evict_for_node() is > > the only user outside of execbuf that currently peeks at the flag to > > convert an overlapping softpinned request from ENOSPC to EINVAL. Retract > > this nicety and only report ENOSPC if the location is in current use, > > either due to this execbuf or another. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Same reasons as for patch 3, I don't think we have to do this at all. This is already undefined behaviour. That field is protected by struct_mutex and being evaluated outside of that lock. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
