On Tue, 29 Oct 2019, Manasi Navare <manasi.d.navare@xxxxxxxxx> wrote:
> On Tue, Oct 29, 2019 at 12:39:47PM +0200, Jani Nikula wrote:
>> The intel_dp_link_training.h include has no need or place in
>> intel_display.h. Include it in intel_display.c instead.
>>
>> Cc:
>>
>> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
>> Fixes: eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync")
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Ah okay yes makes sens eto add it in intel_display.c Thanks for fixing this.
> After removing the redundant Cc:,
>
> Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
Finally pushed, thanks for the review.
BR,
Jani.
>
> Manasi
>
>> ---
>> drivers/gpu/drm/i915/display/intel_display.c | 1 +
>> drivers/gpu/drm/i915/display/intel_display.h | 1 -
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index 9dce2e9e5376..505d697f6b4c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -66,6 +66,7 @@
>> #include "intel_cdclk.h"
>> #include "intel_color.h"
>> #include "intel_display_types.h"
>> +#include "intel_dp_link_training.h"
>> #include "intel_fbc.h"
>> #include "intel_fbdev.h"
>> #include "intel_fifo_underrun.h"
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>> index ca7ca2804d8b..7278f9aee8ca 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> @@ -27,7 +27,6 @@
>>
>> #include <drm/drm_util.h>
>> #include <drm/i915_drm.h>
>> -#include "intel_dp_link_training.h"
>>
>> enum link_m_n_set;
>> struct dpll;
>> --
>> 2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
