Quoting Dan Carpenter (2019-11-06 13:48:14)
> Hello Chris Wilson,
>
> The patch a4e7ccdac38e: "drm/i915: Move context management under GEM"
> from Oct 4, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt()
> warn: 'ctx->mutex' both locked and unlocked.
>
> drivers/gpu/drm/i915/gem/i915_gem_context.c
> 940 rcu_read_unlock();
> 941 if (!vm)
> 942 return -ENOENT;
> 943
> 944 err = mutex_lock_interruptible(&ctx->mutex);
> 945 if (err)
> 946 goto out;
> 947
> 948 if (i915_gem_context_is_closed(ctx)) {
> 949 err = -ENOENT;
> 950 goto out;
> ^^^^^^^^
> This should be goto unlock?
Yes. Many thanks for the bug report.
https://patchwork.freedesktop.org/patch/339213/?series=69070&rev=1
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
