Quoting Niranjana Vishwanathapura (2019-11-06 00:02:03) > We don't need rcu read side critical section to call pid_nr(), > remove it. > > Cc: Chris P Wilson <chris.p.wilson@xxxxxxxxx> > Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index e8b67f5e521d..1f2f266f26af 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1230,10 +1230,7 @@ static void record_request(const struct i915_request *request, > erq->start = i915_ggtt_offset(request->ring->vma); > erq->head = request->head; > erq->tail = request->tail; > - > - rcu_read_lock(); > erq->pid = ctx->pid ? pid_nr(ctx->pid) : 0; > - rcu_read_unlock(); Ok, that was just cut'n'paste from pid_task() Reviewed-by: Chris Wilson <chris.p.wilson@xxxxxxxxx> -Chris --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
