On Mon, Oct 21, 2019 at 09:54:48PM -0300, Rodrigo Siqueira wrote:
> Hi,
Hi Rodrigo,
The whole series looks good to me, you can add my Reviewed-by tag if you want.
Do you plan to push the patches into igt?
Best regards,
Liviu
>
> A couple of months ago, I updated and re-submitted a patchset made by
> Brian Starkey and Liviu Dudau for adding a writeback connectors test to
> IGT. It is important to highlight that DRM already have writeback
> connectors support, which is a way to expose in DRM the hardware
> functionality from display engines that allows writing back into memory
> the result of the DE's composition of supported planes.
>
> After I resubmitted the patchset, Simon Ser provides a long and detailed
> review for all of the patches (thanks Simon). As a result, I finally had
> time to go through all the details and prepare this new version. Follows
> some notes:
>
> 1. Patchset author
>
> Brian Starkey is the original author of this patchset, and I'm just
> trying to upstream his changes. Note that during this patch submission,
> the mail server from google going to overwrite Brian's mail by mine;
> this happens on the mail server side for avoiding malicious users to
> send emails as someone else. Note that I could spend time figuring out
> how to fix it, but I think this is not worth since I can fix it during
> the merge process (if it got accepted).
>
> 2. Drop the clone commits from the series
>
> After Simon's review, we decided to drop the last two patches of the
> original series since it was related to cloning output, and VKMS does
> not support it yet. However, after we finish with this series, I can try
> to take a look at this feature or maybe propose it as a GSoC/Outreachy
> project.
>
> 3. Changes
>
> Most of the changes happened in the second patch.
>
> Thanks
>
> Brian Starkey (4):
> lib/igt_kms: Add writeback support
> kms_writeback: Add initial writeback tests
> lib: Add function to hash a framebuffer
> kms_writeback: Add writeback-check-output
>
> lib/igt_fb.c | 68 +++++++
> lib/igt_fb.h | 2 +
> lib/igt_kms.c | 59 ++++++
> lib/igt_kms.h | 6 +
> tests/Makefile.sources | 1 +
> tests/kms_writeback.c | 413 +++++++++++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 7 files changed, 550 insertions(+)
> create mode 100644 tests/kms_writeback.c
>
> --
> 2.23.0
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
