== Series Details == Series: Refactor Gen11+ SAGV support (rev7) URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3f4410bb65da drm/i915: Refactor intel_can_enable_sagv -:189: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #189: FILE: drivers/gpu/drm/i915/intel_pm.c:3836: + for_each_new_intel_crtc_in_state(state, crtc, + new_crtc_state, i) { -:269: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #269: FILE: drivers/gpu/drm/i915/intel_pm.c:3916: + bool state_sagv_masked = \ -:274: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #274: FILE: drivers/gpu/drm/i915/intel_pm.c:3921: + bool sagv_masked = \ -:318: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #318: FILE: drivers/gpu/drm/i915/intel_pm.c:4342: +tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state, + struct skl_ddb_allocation *ddb /* out */) -:436: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #436: FILE: drivers/gpu/drm/i915/intel_pm.c:4991: + skl_compute_plane_wm(crtc_state, 0, latency, + wm_params, &levels[0], -:438: CHECK:BRACES: Unbalanced braces around else statement #438: FILE: drivers/gpu/drm/i915/intel_pm.c:4993: + } else -:440: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #440: FILE: drivers/gpu/drm/i915/intel_pm.c:4995: + memcpy(&plane_wm->sagv_wm0, &levels[0], + sizeof(struct skl_wm_level)); -:503: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #503: FILE: drivers/gpu/drm/i915/intel_pm.c:5681: + for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, + new_crtc_state, i) { -:509: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #509: FILE: drivers/gpu/drm/i915/intel_pm.c:5687: + struct skl_plane_wm *plane_wm = \ -:532: WARNING:LINE_SPACING: Missing a blank line after declarations #532: FILE: drivers/gpu/drm/i915/intel_pm.c:5710: + int pipe_bit = BIT(crtc->pipe); + state->crtc_sagv_mask |= pipe_bit; total: 0 errors, 4 warnings, 6 checks, 468 lines checked 93776c9f8bb6 drm/i915: Restrict qgv points which don't have enough bandwidth. -:87: CHECK:LINE_SPACING: Please don't use multiple blank lines #87: FILE: drivers/gpu/drm/i915/display/intel_bw.c:19: + -:118: CHECK:LINE_SPACING: Please don't use multiple blank lines #118: FILE: drivers/gpu/drm/i915/display/intel_bw.c:139: + + -:323: CHECK:BRACES: braces {} should be used on all arms of this statement #323: FILE: drivers/gpu/drm/i915/display/intel_display.c:14796: + if (INTEL_GEN(dev_priv) < 11) { [...] + } else [...] -:326: CHECK:BRACES: Unbalanced braces around else statement #326: FILE: drivers/gpu/drm/i915/display/intel_display.c:14799: + } else total: 0 errors, 0 warnings, 4 checks, 347 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx