Hi Chris, On Wed, Oct 30, 2019 at 10:38:27AM +0000, Chris Wilson wrote: > Currently we shutdown rc6 during i915_gem_resume() but this is called > during the preparation phase (i915_drm_prepare) for all suspend paths, > but we only want to shutdown rc6 for S3+. Move the actual shutdown to > i915_gem_suspend_late(). > > We then need to differentiate between suspend targets, to distinguish S0 > (s2idle) where the device is kept awake but needs to be in a low power > mode (the same as runtime suspend) from the device suspend levels where > we lose control of HW and so must disable any HW access to dangling > memory. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111909 > Fixes: c113236718e8 ("drm/i915: Extract GT render sleep (rc6) management") > Testcase: igt/gem_exec_suspend/power-S0 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Andi Shyti <andi.shyti@xxxxxxxxx> Looks OK! Thanks! Acked-by: Andi Shyti <andi.shyti@xxxxxxxxx> Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
