== Series Details == Series: tgl: MST support URL : https://patchwork.freedesktop.org/series/68749/ State : warning == Summary == $ dim checkpatch origin/drm-tip dd2dcb37cff0 drm/i915: Add for_each_new_intel_connector_in_state() -:26: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #26: FILE: drivers/gpu/drm/i915/display/intel_display.h:455: +#define for_each_new_intel_connector_in_state(__state, connector, new_connector_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.num_connector; \ + (__i)++) \ + for_each_if ((__state)->base.connectors[__i].ptr && \ + ((connector) = to_intel_connector((__state)->base.connectors[__i].ptr), \ + (new_connector_state) = to_intel_digital_connector_state((__state)->base.connectors[__i].new_state), 1)) -:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #26: FILE: drivers/gpu/drm/i915/display/intel_display.h:455: +#define for_each_new_intel_connector_in_state(__state, connector, new_connector_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.num_connector; \ + (__i)++) \ + for_each_if ((__state)->base.connectors[__i].ptr && \ + ((connector) = to_intel_connector((__state)->base.connectors[__i].ptr), \ + (new_connector_state) = to_intel_digital_connector_state((__state)->base.connectors[__i].new_state), 1)) -:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #26: FILE: drivers/gpu/drm/i915/display/intel_display.h:455: +#define for_each_new_intel_connector_in_state(__state, connector, new_connector_state, __i) \ + for ((__i) = 0; \ + (__i) < (__state)->base.num_connector; \ + (__i)++) \ + for_each_if ((__state)->base.connectors[__i].ptr && \ + ((connector) = to_intel_connector((__state)->base.connectors[__i].ptr), \ + (new_connector_state) = to_intel_digital_connector_state((__state)->base.connectors[__i].new_state), 1)) -:30: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #30: FILE: drivers/gpu/drm/i915/display/intel_display.h:459: + for_each_if ((__state)->base.connectors[__i].ptr && \ -:31: WARNING:LONG_LINE: line over 100 characters #31: FILE: drivers/gpu/drm/i915/display/intel_display.h:460: + ((connector) = to_intel_connector((__state)->base.connectors[__i].ptr), \ -:32: WARNING:LONG_LINE: line over 100 characters #32: FILE: drivers/gpu/drm/i915/display/intel_display.h:461: + (new_connector_state) = to_intel_digital_connector_state((__state)->base.connectors[__i].new_state), 1)) total: 1 errors, 3 warnings, 2 checks, 14 lines checked 19dd8fd8abe5 drm/i915: add wrappers to get intel connector state -:24: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #24: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1534: + return to_intel_digital_connector_state( -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #26: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1536: + drm_atomic_get_new_connector_state(&state->base, + &connector->base)); -:33: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #33: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1543: + return to_intel_digital_connector_state( -:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #35: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1545: + drm_atomic_get_old_connector_state(&state->base, + &connector->base)); total: 0 errors, 0 warnings, 4 checks, 24 lines checked 86b8e6f1be04 drm/i915/tgl: do not enable transcoder clock twice on MST 4bd25aeecad6 drm/i915: avoid reading DP_TP_CTL twice a52f9afe98d1 drm/i915/tgl: Select master transcoder in DP MST _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
