== Series Details == Series: series starting with [CI,01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. URL : https://patchwork.freedesktop.org/series/68694/ State : warning == Summary == $ dim checkpatch origin/drm-tip 874fbe7ef3ea drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: In case of intel_modeset_all_pipes() this is not yet done after atomic_check, -:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #87: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:387: + DRM_DEBUG_KMS("Failed to add [PLANE:%d] to drm_state: %li\n", + plane->base.base.id, PTR_ERR(plane_state)); total: 0 errors, 1 warnings, 1 checks, 185 lines checked 4f1d48454ee1 drm/i915: Handle a few more cases for crtc hw/uapi split, v3. 3687c3a98282 drm/i915: Add aliases for uapi and hw to crtc_state -:67: WARNING:LONG_LINE: line over 100 characters #67: FILE: drivers/gpu/drm/i915/display/intel_display.h:453: + to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)))) total: 0 errors, 1 warnings, 0 checks, 83 lines checked ffd35e35db81 drm/i915: Perform manual conversions for crtc uapi/hw split, v2. 05e6016b7e5d drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw. -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Split up crtc_state->base to hw where appropriate. This is done using the following patch: -:1423: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1423: FILE: drivers/gpu/drm/i915/display/intel_display.c:17296: + crtc_state->hw.active = crtc_state->hw.enable = total: 0 errors, 1 warnings, 1 checks, 2068 lines checked 3a334a01e03a drm/i915: Perform automated conversions for crtc uapi/hw split, base -> uapi. -:2400: ERROR:CODE_INDENT: code indent should use tabs where possible #2400: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211: +^I^I^I^I new_crtc_state->uapi.event);$ -:2400: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2400: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211: + drm_crtc_arm_vblank_event(&crtc->base, + new_crtc_state->uapi.event); total: 1 errors, 0 warnings, 1 checks, 2552 lines checked 073cf0005a71 drm/i915: Complete crtc hw/uapi split, v4. -:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #15: - Clear crtc_state->hw on disable, instead of using clear_intel_crtc_state(). total: 0 errors, 1 warnings, 0 checks, 245 lines checked c602b94e8725 drm/i915: Add aliases for uapi and hw to plane_state -:49: WARNING:LINE_SPACING: Missing a blank line after declarations #49: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:112: + struct intel_plane_state *plane_state = to_intel_plane_state(state); + WARN_ON(plane_state->vma); total: 0 errors, 1 warnings, 0 checks, 59 lines checked c4c09c715aaa drm/i915: Perform manual conversions for plane uapi/hw split bf75017f95eb drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw. -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; -:922: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane_state->hw.fb" #922: FILE: drivers/gpu/drm/i915/intel_pm.c:804: + return plane_state->hw.fb != NULL; total: 0 errors, 1 warnings, 1 checks, 903 lines checked 23683bbe1ff3 drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi. -:745: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #745: FILE: drivers/gpu/drm/i915/display/intel_display.c:11181: + unsigned width = drm_rect_width(&plane_state->uapi.dst); -:746: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #746: FILE: drivers/gpu/drm/i915/display/intel_display.c:11182: + unsigned height = drm_rect_height(&plane_state->uapi.dst); -:814: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #814: FILE: drivers/gpu/drm/i915/display/intel_display.c:11784: + plane_state->uapi.visible = visible = false; -:1614: WARNING:LONG_LINE: line over 100 characters #1614: FILE: drivers/gpu/drm/i915/intel_pm.c:3103: + (drm_rect_width(&sprstate->uapi.dst) != drm_rect_width(&sprstate->uapi.src) >> 16 || -:1615: WARNING:LONG_LINE: line over 100 characters #1615: FILE: drivers/gpu/drm/i915/intel_pm.c:3104: + drm_rect_height(&sprstate->uapi.dst) != drm_rect_height(&sprstate->uapi.src) >> 16); total: 0 errors, 4 warnings, 1 checks, 1510 lines checked 89805e743cb0 drm/i915: Complete plane hw and uapi split, v2. -:139: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u16' over 'uint16_t' #139: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:538: + uint16_t pixel_blend_mode; total: 0 errors, 0 warnings, 1 checks, 107 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
