== Series Details == Series: series starting with [01/14] drm/i915: Rework watermark readout to use plane api URL : https://patchwork.freedesktop.org/series/68519/ State : warning == Summary == $ dim checkpatch origin/drm-tip 22333473c76c drm/i915: Rework watermark readout to use plane api 198f3ae74f1a drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: In case of intel_modeset_all_pipes() this is not yet done after atomic_check, -:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #87: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:387: + DRM_DEBUG_KMS("Failed to add [PLANE:%d] to drm_state: %li\n", + plane->base.base.id, PTR_ERR(plane_state)); total: 0 errors, 1 warnings, 1 checks, 185 lines checked 083b2450c140 drm/i915: Handle a few more cases for crtc hw/uapi split, v3. b48dff12ef91 drm/i915: Add aliases for uapi and hw to crtc_state -:67: WARNING:LONG_LINE: line over 100 characters #67: FILE: drivers/gpu/drm/i915/display/intel_display.h:453: + to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)))) total: 0 errors, 1 warnings, 0 checks, 83 lines checked 6d9fcb9131c2 drm/i915: Perform manual conversions for crtc uapi/hw split, v2. 1e26da0561d3 drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw. -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Split up crtc_state->base to hw where appropriate. This is done using the following patch: -:1424: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1424: FILE: drivers/gpu/drm/i915/display/intel_display.c:17104: + crtc_state->hw.active = crtc_state->hw.enable = total: 0 errors, 1 warnings, 1 checks, 2089 lines checked 702358ac8359 drm/i915: Perform automated conversions for crtc uapi/hw split, base -> uapi. -:2409: ERROR:CODE_INDENT: code indent should use tabs where possible #2409: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211: +^I^I^I^I new_crtc_state->uapi.event);$ -:2409: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2409: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211: + drm_crtc_arm_vblank_event(&crtc->base, + new_crtc_state->uapi.event); total: 1 errors, 0 warnings, 1 checks, 2568 lines checked bab1c99201bb drm/i915: Complete crtc hw/uapi split, v3. -:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #15: - Clear crtc_state->hw on disable, instead of using clear_intel_crtc_state(). total: 0 errors, 1 warnings, 0 checks, 217 lines checked ca8f0c896f5f drm/i915: Add aliases for uapi and hw to plane_state -:49: WARNING:LINE_SPACING: Missing a blank line after declarations #49: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:112: + struct intel_plane_state *plane_state = to_intel_plane_state(state); + WARN_ON(plane_state->vma); total: 0 errors, 1 warnings, 0 checks, 59 lines checked d999f2905a18 drm/i915: Perform manual conversions for plane uapi/hw split 5fe68e3dbc52 drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw. -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; -:832: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane_state->hw.fb" #832: FILE: drivers/gpu/drm/i915/intel_pm.c:814: + return plane_state->hw.fb != NULL; total: 0 errors, 1 warnings, 1 checks, 836 lines checked 511cefb79332 drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi. -:731: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #731: FILE: drivers/gpu/drm/i915/display/intel_display.c:11105: + unsigned width = drm_rect_width(&plane_state->uapi.dst); -:732: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #732: FILE: drivers/gpu/drm/i915/display/intel_display.c:11106: + unsigned height = drm_rect_height(&plane_state->uapi.dst); -:800: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #800: FILE: drivers/gpu/drm/i915/display/intel_display.c:11708: + plane_state->uapi.visible = visible = false; -:1528: WARNING:LONG_LINE: line over 100 characters #1528: FILE: drivers/gpu/drm/i915/intel_pm.c:3113: + (drm_rect_width(&sprstate->uapi.dst) != drm_rect_width(&sprstate->uapi.src) >> 16 || -:1529: WARNING:LONG_LINE: line over 100 characters #1529: FILE: drivers/gpu/drm/i915/intel_pm.c:3114: + drm_rect_height(&sprstate->uapi.dst) != drm_rect_height(&sprstate->uapi.src) >> 16); total: 0 errors, 4 warnings, 1 checks, 1431 lines checked 6d89b589ae93 drm/i915: Complete plane hw and uapi split, v2. -:139: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u16' over 'uint16_t' #139: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:530: + uint16_t pixel_blend_mode; total: 0 errors, 0 warnings, 1 checks, 107 lines checked d85928cc4a61 drm/i915: Remove special case slave handling during hw programming, v3. -:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #16: - Use the correct color_plane for pre-gen11 by using planar_linked_plane != NULL. total: 0 errors, 1 warnings, 0 checks, 201 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
