On Thu, Oct 24, 2019 at 10:51:20AM +0300, Jani Nikula wrote:
> On Wed, 23 Oct 2019, Manasi Navare <manasi.d.navare@xxxxxxxxx> wrote:
> > On Tue, Oct 22, 2019 at 05:03:00PM +0300, Jani Nikula wrote:
> >> Add definition for block 56, the compression parameters.
> >>
> >
> > Would this be used on DP connectors for DSC as well?
>
> I think only if needed; with DSI it's not possible to query the
> parameters from the display.
>
Ok got it! So then for DP we do get everything from the DPCDs
Thanks for the clarification.
Regards
Manasi
> BR,
> Jani.
>
> >
> > Manasi
> >
> >> Cc: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>
> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 50 +++++++++++++++++++
> >> 1 file changed, 50 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> index e3045ced4bfe..7f222196d2d5 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> >> @@ -114,6 +114,7 @@ enum bdb_block_id {
> >> BDB_LVDS_POWER = 44,
> >> BDB_MIPI_CONFIG = 52,
> >> BDB_MIPI_SEQUENCE = 53,
> >> + BDB_COMPRESSION_PARAMETERS = 56,
> >> BDB_SKIP = 254, /* VBIOS private block, ignore */
> >> };
> >>
> >> @@ -811,4 +812,53 @@ struct bdb_mipi_sequence {
> >> u8 data[0]; /* up to 6 variable length blocks */
> >> } __packed;
> >>
> >> +/*
> >> + * Block 56 - Compression Parameters
> >> + */
> >> +
> >> +#define VBT_RC_BUFFER_BLOCK_SIZE_1KB 0
> >> +#define VBT_RC_BUFFER_BLOCK_SIZE_4KB 1
> >> +#define VBT_RC_BUFFER_BLOCK_SIZE_16KB 2
> >> +#define VBT_RC_BUFFER_BLOCK_SIZE_64KB 3
> >> +
> >> +#define VBT_DSC_LINE_BUFFER_DEPTH(vbt_value) ((vbt_value) + 8) /* bits */
> >> +#define VBT_DSC_MAX_BPP(vbt_value) (6 + (vbt_value) * 2)
> >> +
> >> +struct dsc_compression_parameters_entry {
> >> + u8 version_major:4;
> >> + u8 version_minor:4;
> >> +
> >> + u8 rc_buffer_block_size:2;
> >> + u8 reserved1:6;
> >> +
> >> + /*
> >> + * Buffer size in bytes:
> >> + *
> >> + * 4 ^ rc_buffer_block_size * 1024 * (rc_buffer_size + 1) bytes
> >> + */
> >> + u8 rc_buffer_size;
> >> + u32 slices_per_line;
> >> +
> >> + u8 line_buffer_depth:4;
> >> + u8 reserved2:4;
> >> +
> >> + /* Flag Bits 1 */
> >> + u8 block_prediction_enable:1;
> >> + u8 reserved3:7;
> >> +
> >> + u8 max_bpp; /* mapping */
> >> +
> >> + /* Color depth capabilities */
> >> + u8 reserved4:1;
> >> + u8 support_8bpc:1;
> >> + u8 support_10bpc:1;
> >> + u8 support_12bpc:1;
> >> + u8 reserved5:4;
> >> +} __packed;
> >> +
> >> +struct bdb_compression_parameters {
> >> + u16 entry_size;
> >> + struct dsc_compression_parameters_entry data[16];
> >> +} __packed;
> >> +
> >> #endif /* _INTEL_VBT_DEFS_H_ */
> >> --
> >> 2.20.1
> >>
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
