Re: [PATCH i-g-t 2/2] tests/gem_exec_reloc: Calculate softpin offsets from batch size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On Wednesday, October 23, 2019 11:13:02 AM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-10-23 10:07:52)
> > From: Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxx>
> > 
> > The basic-range subtest assumes 4kB minimum batch size.  On future
> > backends with possibly bigger minimum batch sizes this subtest will
> > fail as buffer objects may overlap.  To avoid object overlapping,
> > offsets need to be calculated with actual minimum batch size in mind.
> > 
> > Replace hardcoded constants corresponding to the assumed 4kB minimum
> > batch size with values calculated from a variable supposed to represent
> > actual batch size.  For now, the variable is still initialized with the
> > 4kB value, suitable for backends currently supported by IGT.
> 
> You could do this entirely within the reloc API, no? By probing whether
> a 4KiB offset is legal?

Thanks for the hint, I'll try to take this path.
Janusz

> -Chris
> 




_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux