== Series Details == Series: series starting with [1/4] drm/i915/gt: Set unused mocs entry to follow PTE on tgl as on all others (rev2) URL : https://patchwork.freedesktop.org/series/68388/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0331f204fce6 drm/i915/gt: Set unused mocs entry to follow PTE on tgl as on all others 552119a6b590 drm/i915/gt: Tidy up debug-warns for the mocs control table 6ddfeb99f8cc drm/i915/gt: Refactor mocs loops into single control macro -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:344: +#define for_each_mocs(mocs, t, i) \ + for (i = 0; \ + i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\ + i++) -:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues #66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:344: +#define for_each_mocs(mocs, t, i) \ + for (i = 0; \ + i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\ + i++) -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:344: +#define for_each_mocs(mocs, t, i) \ + for (i = 0; \ + i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\ + i++) -:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects? #128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:399: +#define for_each_l3cc(l3cc, t, i) \ + for (i = 0; \ + i < (t->n_entries + 1) / 2 ? \ + (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \ + get_entry_l3cc(t, 2 * i + 1))), 1 : \ + 0; \ + i++) -:128: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues #128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:399: +#define for_each_l3cc(l3cc, t, i) \ + for (i = 0; \ + i < (t->n_entries + 1) / 2 ? \ + (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \ + get_entry_l3cc(t, 2 * i + 1))), 1 : \ + 0; \ + i++) -:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:399: +#define for_each_l3cc(l3cc, t, i) \ + for (i = 0; \ + i < (t->n_entries + 1) / 2 ? \ + (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \ + get_entry_l3cc(t, 2 * i + 1))), 1 : \ + 0; \ + i++) total: 0 errors, 0 warnings, 6 checks, 182 lines checked 49c1502301e4 drm/i915/selftests: Add coverage of mocs registers -:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 -:34: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #34: FILE: drivers/gpu/drm/i915/gt/selftest_mocs.c:1: +/* -:35: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #35: FILE: drivers/gpu/drm/i915/gt/selftest_mocs.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 407 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
