On Tue, Oct 22, 2019 at 07:34:13PM +0530, Animesh Manna wrote: > > On 10/22/2019 4:27 AM, Manasi Navare wrote: > >On Thu, Oct 03, 2019 at 08:36:49PM +0530, Animesh Manna wrote: > >>vswing/pre-emphasis adjustment calculation is needed in processing > >>of auto phy compliance request other than link training, so moved > >>the same function in intel_dp.c. > >> > >>No functional change. > >You could just make it a non static function instead of moving to intel_dp.c > > Initially I did the same ... :) > Later I thought intel_dp_link_training.c file is mainly focused only on link > training process, start_link_train() and stop_link_train() are only exposed. > I thought I may not be allowed to expose intel_get_adjust_train() as it is > not exclusive for link training. > Please let me know your view. Infact now that I look at this, i think the prepare_phy_test function should only probably get the drm_get_phy_test_pattern and populate in the intel_dp_compliance structure and then adjust train and all that can happen right before pattern update which will need to happen in atomic_commit_tail. How do you handle the regular link training sequence in the case of PHY test? What happens to the adjust train the the regular link training clock recovery and channel eq stages? Manasi > > Regards, > Animesh _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
