On Tue, Oct 2, 2012 at 9:51 PM, Paulo Zanoni <przanoni at gmail.com> wrote: > +static int haswell_crtc_mode_set(struct drm_crtc *crtc, > + struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode, > + int x, int y, > + struct drm_framebuffer *fb) > +{ .. > + if (IS_HASWELL(dev)) > + if (!intel_ddi_pll_mode_set(crtc, adjusted_mode->clock)) > + return -EINVAL; I know the patch is going to be re-ordered, but IS_HASWELL() can be dropped when adding intel_ddi_pll_mode_set() back. -- Damien