== Series Details == Series: DP MST Refactors + debugging tools + suspend/resume reprobing URL : https://patchwork.freedesktop.org/series/68359/ State : warning == Summary == $ dim checkpatch origin/drm-tip dfa95c8ecbba drm/dp_mst: Destroy MSTBs asynchronously -:313: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #313: FILE: include/drm/drm_dp_mst_helper.h:592: + struct mutex delayed_destroy_lock; total: 0 errors, 0 warnings, 1 checks, 263 lines checked ce25890ebeae drm/dp_mst: Remove PDT teardown in drm_dp_destroy_port() and refactor bb814cd52770 drm/dp_mst: Refactor pdt setup/teardown, add more locking 8ccc1d69d33c drm/dp_mst: Handle UP requests asynchronously 01ea755bc87f drm/dp_mst: Add probe_lock 6ef467a9247f drm/dp_mst: Protect drm_dp_mst_port members with locking -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: This is a complicated one. Essentially, there's currently a problem in the MST total: 0 errors, 1 warnings, 0 checks, 635 lines checked 1c3c0e119049 drm/dp_mst: Don't forget to update port->input in drm_dp_mst_handle_conn_stat() 5afcdf3d0133 drm/dp_mst: Lessen indenting in drm_dp_mst_topology_mgr_resume() 1e380e0d635f drm/nouveau: Don't grab runtime PM refs for HPD IRQs -:43: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #43: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:1138: + if ((nv_encoder = find_encoder(connector, DCB_OUTPUT_DP))) -:66: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #66: FILE: drivers/gpu/drm/nouveau/nouveau_connector.c:1166: + if ((nv_encoder = find_encoder(connector, DCB_OUTPUT_DP))) { total: 2 errors, 0 warnings, 0 checks, 48 lines checked 0f7f40f17cf0 drm/nouveau: Resume hotplug interrupts earlier -:39: WARNING:LINE_SPACING: Missing a blank line after declarations #39: FILE: drivers/gpu/drm/nouveau/nouveau_display.c:417: + struct nouveau_connector *conn = nouveau_connector(connector); + nvif_notify_get(&conn->hpd); total: 0 errors, 1 warnings, 0 checks, 31 lines checked b7d9bc12c03e drm/amdgpu: Iterate through DRM connectors correctly 58f9462ec3a8 drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology 2e43a68e1d76 drm/dp_mst: Add basic topology reprobing when resuming -:211: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #211: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2261: +static int drm_dp_check_and_send_link_address(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_branch *mstb) -:277: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #277: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2581: +static int drm_dp_send_link_address(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_branch *mstb) total: 0 errors, 0 warnings, 2 checks, 373 lines checked 4e7abcd7af53 drm/dp_mst: Add topology ref history tracking for debugging -:141: WARNING:RETURN_VOID: void function return statements are not generally useful #141: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1459: + return; +} -:185: WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'. #185: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1503: + drm_printf(&p, + "%s (%p/%px) topology count reached 0, dumping history:\n", + type_str, ptr, ptr); -:380: WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'. #380: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1798: + DRM_DEBUG("port %p/%px (%d)\n", + port, port, kref_read(&port->topology_kref) - 1); total: 0 errors, 3 warnings, 0 checks, 413 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
