== Series Details == Series: mdev based hardware virtio offloading support (rev5) URL : https://patchwork.freedesktop.org/series/66989/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2d2711d83299 mdev: class id support 335f12f84dd7 modpost: add support for mdev class id 1c27243b07bd mdev: introduce device specific ops -:468: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #468: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 590 lines checked 0cf5dbea3c83 mdev: introduce virtio device and its device ops -:25: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #25: FILE: drivers/vfio/mdev/mdev_core.c:66: + BUG_ON(mdev->class_id); -:51: ERROR:CODE_INDENT: code indent should use tabs where possible #51: FILE: include/linux/mdev.h:116: + const struct virtio_mdev_device_ops *virtio_ops);$ -:51: WARNING:LEADING_SPACE: please, no spaces at the start of a line #51: FILE: include/linux/mdev.h:116: + const struct virtio_mdev_device_ops *virtio_ops);$ -:64: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #64: new file mode 100644 -:155: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #155: FILE: include/linux/virtio_mdev.h:87: + * @get_status: ^I^IGet the device status$ -:158: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #158: FILE: include/linux/virtio_mdev.h:90: + * @set_status: ^I^ISet the device status$ -:161: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #161: FILE: include/linux/virtio_mdev.h:93: + * @get_config: ^I^IRead from device specific configuration space$ -:168: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #168: FILE: include/linux/virtio_mdev.h:100: + * @set_config: ^I^IWrite to device specific configuration space$ total: 1 errors, 7 warnings, 0 checks, 191 lines checked 7566405601ce virtio: introduce a mdev based transport -:26: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #26: FILE: drivers/virtio/Kconfig:46: +config VIRTIO_MDEV_DEVICE -:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 -:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #106: FILE: drivers/virtio/virtio_mdev.c:56: +static void virtio_mdev_get(struct virtio_device *vdev, unsigned offset, -:107: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #107: FILE: drivers/virtio/virtio_mdev.c:57: + void *buf, unsigned len) -:115: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #115: FILE: drivers/virtio/virtio_mdev.c:65: +static void virtio_mdev_set(struct virtio_device *vdev, unsigned offset, -:116: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #116: FILE: drivers/virtio/virtio_mdev.c:66: + const void *buf, unsigned len) -:183: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #183: FILE: drivers/virtio/virtio_mdev.c:133: +virtio_mdev_setup_vq(struct virtio_device *vdev, unsigned index, -:262: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #262: FILE: drivers/virtio/virtio_mdev.c:212: + +} -:294: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #294: FILE: drivers/virtio/virtio_mdev.c:244: +static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs, total: 0 errors, 8 warnings, 1 checks, 426 lines checked 5dd612418610 docs: sample driver to demonstrate how to implement virtio-mdev framework -:39: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #39: FILE: samples/Kconfig:134: +config SAMPLE_VIRTIO_MDEV_NET -:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 -:147: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #147: FILE: samples/vfio-mdev/mvnet.c:84: + spinlock_t lock; -:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #180: FILE: samples/vfio-mdev/mvnet.c:117: + vringh_init_kern(&vq->vring, mvnet_features, MVNET_QUEUE_MAX, + false, 0, 0, 0); -:285: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!addr" #285: FILE: samples/vfio-mdev/mvnet.c:222: + if (addr == NULL) -:288: CHECK:SPACING: No space is necessary after a cast #288: FILE: samples/vfio-mdev/mvnet.c:225: + *dma_addr = (dma_addr_t) addr; -:318: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*mvnet)...) over kzalloc(sizeof(struct mvnet_state)...) #318: FILE: samples/vfio-mdev/mvnet.c:255: + mvnet = kzalloc(sizeof(struct mvnet_state), GFP_KERNEL); -:319: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!mvnet" #319: FILE: samples/vfio-mdev/mvnet.c:256: + if (mvnet == NULL) -:375: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #375: FILE: samples/vfio-mdev/mvnet.c:312: +sample_mvnet_dev_show(struct device *dev, struct device_attribute *attr, + char *buf) total: 0 errors, 2 warnings, 7 checks, 715 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
