Re: [igt-dev] [PATCH i-g-t] lib/i915: Bump conservative threshold for ring size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/10/2019 09:27, Chris Wilson wrote:
We are still hitting the occasional stall upon submission, so be extra
caution and leave one more spare.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
---
  lib/i915/gem_ring.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/i915/gem_ring.c b/lib/i915/gem_ring.c
index 272264659..9f099edff 100644
--- a/lib/i915/gem_ring.c
+++ b/lib/i915/gem_ring.c
@@ -104,7 +104,7 @@ __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags
  	} while (1);
igt_assert_eq(__execbuf(fd, &execbuf), -EINTR);
-	igt_assert(count > 1);
+	igt_assert(count > 2);
memset(&itv, 0, sizeof(itv));
  	setitimer(ITIMER_REAL, &itv, NULL);
@@ -120,7 +120,7 @@ __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags
  	gem_quiescent_gpu(fd);
/* Be conservative in case we must wrap later */
-	return count - 1;
+	return count - 2;
  }
/**


Will one make a difference?

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux