Another attempt at trying to cleanup the probe/remove wrt display. TL;DR: It's a mess. I'm trying to chop up the intel_modeset_*() functions in intel_display.c to smaller pieces, and eventually remove the extra i915_driver_modeset_*() layer from i915_drv.c. The intermediate steps aren't the prettiest. The error paths in particular are hideous. (Not that they are great now.) But I'm trying to probe (eh) if this would be a workable direction. BR, Jani. Jani Nikula (11): drm/i915: register vga switcheroo later, unregister earlier drm/i915: switch i915_driver_probe() to use i915 local variable drm/i915: keep power domains init/remove calls at the same level drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall drm/i915: split i915_driver_modeset_probe() to pre/post irq install drm/i915: split intel_modeset_init() to pre/post irq install drm/i915: split intel_modeset_init() pre/post gem init drm/i915: move more display related probe/remove stuff to display drm/i915: move modeset probe failures down to intel_display.c drm/i915: remove the now redundant i915_driver_modeset_* call layer drivers/gpu/drm/i915/display/intel_display.c | 82 +++++++-- drivers/gpu/drm/i915/display/intel_display.h | 3 + drivers/gpu/drm/i915/i915_drv.c | 183 +++++++------------ 3 files changed, 141 insertions(+), 127 deletions(-) -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx