== Series Details == Series: drm/i915: customize DPCD brightness control for specific panel URL : https://patchwork.freedesktop.org/series/67595/ State : warning == Summary == $ dim checkpatch origin/drm-tip 84d67190854b drm/i915: customize DPCD brightness control for specific panel -:88: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #88: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:39: + uint8_t read_val[2] = { 0x0 }; -:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #93: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:44: + DRM_DEBUG_KMS("Failed to read DPCD register %x\n", + DPCD_EDP_BRIGHTNESS_NITS); -:106: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #106: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:57: + uint8_t new_vals[4]; -:121: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #121: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:72: +static void intel_dp_aux_enable_customize_backlight(const struct intel_crtc_state *crtc_state, + const struct drm_connector_state *conn_state) -:125: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #125: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:76: + uint8_t read_val[4], i; -:126: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #126: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:77: + uint8_t write_val[8] = {0x00, 0x00, 0xF0, 0x01, 0x90, 0x01, 0x00, 0x00}; -:128: WARNING:LONG_LINE: line over 100 characters #128: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:79: + if (drm_dp_dpcd_write(&intel_dp->aux, DPCD_EDP_PANEL_LUMINANCE_OVERRIDE, write_val, sizeof(write_val)) < 0) -:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #133: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:84: + DRM_DEBUG_KMS("Failed to write %x\n", + DPCD_EDP_BRIGHTNESS_OPTIMIZATION); -:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #143: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:94: + DRM_DEBUG_KMS("Failed to read %x\n", + DPCD_EDP_GETSET_CTRL_PARAMS); -:147: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #147: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:98: + DRM_DEBUG_KMS("Failed to write %x\n", + DPCD_EDP_GETSET_CTRL_PARAMS); -:151: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #151: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:102: + DRM_DEBUG_KMS("Failed to read %x\n", + DPCD_EDP_GETSET_CTRL_PARAMS); -:153: WARNING:LONG_LINE: line over 100 characters #153: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:104: + if (drm_dp_dpcd_read(&intel_dp->aux, DPCD_EDP_CONTENT_LUMINANCE, &read_val, sizeof(read_val)) < 0) -:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #155: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:106: + DRM_DEBUG_KMS("Failed to read %x\n", + DPCD_EDP_CONTENT_LUMINANCE); -:158: WARNING:LONG_LINE: line over 100 characters #158: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:109: + if (drm_dp_dpcd_write(&intel_dp->aux, DPCD_EDP_CONTENT_LUMINANCE, read_val, sizeof(read_val)) < 0) -:160: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #160: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:111: + DRM_DEBUG_KMS("Failed to write %x\n", + DPCD_EDP_CONTENT_LUMINANCE); -:164: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #164: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:115: + DRM_DEBUG_KMS("Failed to read %x\n", + DPCD_EDP_GETSET_CTRL_PARAMS); -:182: WARNING:LONG_LINE: line over 100 characters #182: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:133: +static void intel_dp_aux_disable_customize_backlight(const struct drm_connector_state *old_conn_state) -:186: WARNING:RETURN_VOID: void function return statements are not generally useful #186: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:137: + return; +} -:196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #196: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:340: +static int intel_dp_aux_setup_customize_backlight(struct intel_connector *connector, + enum pipe pipe) total: 0 errors, 5 warnings, 14 checks, 211 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
