Re: [PATCH 1/2] drm/i915: use DRM_ERROR() instead of drm_err()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 02 Oct 2019, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Wed, Oct 02, 2019 at 05:54:04PM +0300, Jani Nikula wrote:
>> Unify on current common usage to allow repurposing drm_err() later. Fix
>> newlines while at it.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Thanks, pushed.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index d99c59e97568..781f6ea7ccf9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -12562,10 +12562,10 @@ pipe_config_infoframe_mismatch(struct drm_i915_private *dev_priv,
>>  		drm_dbg(DRM_UT_KMS, "found");
>>  		hdmi_infoframe_log(KERN_DEBUG, dev_priv->drm.dev, b);
>>  	} else {
>> -		drm_err("mismatch in %s infoframe", name);
>> -		drm_err("expected:");
>> +		DRM_ERROR("mismatch in %s infoframe\n", name);
>> +		DRM_ERROR("expected:\n");
>>  		hdmi_infoframe_log(KERN_ERR, dev_priv->drm.dev, a);
>> -		drm_err("found");
>> +		DRM_ERROR("found:\n");
>>  		hdmi_infoframe_log(KERN_ERR, dev_priv->drm.dev, b);
>>  	}
>>  }
>> @@ -12583,7 +12583,7 @@ pipe_config_mismatch(bool fastset, const char *name, const char *format, ...)
>>  	if (fastset)
>>  		drm_dbg(DRM_UT_KMS, "fastset mismatch in %s %pV", name, &vaf);
>>  	else
>> -		drm_err("mismatch in %s %pV", name, &vaf);
>> +		DRM_ERROR("mismatch in %s %pV\n", name, &vaf);
>>  
>>  	va_end(args);
>>  }
>> -- 
>> 2.20.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux