Re: [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ville,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v5.4-rc1 next-20191001]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-i915-Limit-MST-modes-based-on-plane-size-too/20191002-010404
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_dp_mst.c: In function 'intel_dp_mst_mode_valid':
>> drivers/gpu/drm/i915/display/intel_dp_mst.c:449:9: error: implicit declaration of function 'intel_mode_valid_max_plane_size'; did you mean 'drm_mode_validate_size'? [-Werror=implicit-function-declaration]
     return intel_mode_valid_max_plane_size(dev_priv, mode);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            drm_mode_validate_size
   cc1: some warnings being treated as errors

vim +449 drivers/gpu/drm/i915/display/intel_dp_mst.c

   416	
   417	static enum drm_mode_status
   418	intel_dp_mst_mode_valid(struct drm_connector *connector,
   419				struct drm_display_mode *mode)
   420	{
   421		struct drm_i915_private *dev_priv = to_i915(connector->dev);
   422		struct intel_connector *intel_connector = to_intel_connector(connector);
   423		struct intel_dp *intel_dp = intel_connector->mst_port;
   424		int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
   425		int max_rate, mode_rate, max_lanes, max_link_clock;
   426	
   427		if (drm_connector_is_unregistered(connector))
   428			return MODE_ERROR;
   429	
   430		if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
   431			return MODE_NO_DBLESCAN;
   432	
   433		max_link_clock = intel_dp_max_link_rate(intel_dp);
   434		max_lanes = intel_dp_max_lane_count(intel_dp);
   435	
   436		max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes);
   437		mode_rate = intel_dp_link_required(mode->clock, 18);
   438	
   439		/* TODO - validate mode against available PBN for link */
   440		if (mode->clock < 10000)
   441			return MODE_CLOCK_LOW;
   442	
   443		if (mode->flags & DRM_MODE_FLAG_DBLCLK)
   444			return MODE_H_ILLEGAL;
   445	
   446		if (mode_rate > max_rate || mode->clock > max_dotclk)
   447			return MODE_CLOCK_HIGH;
   448	
 > 449		return intel_mode_valid_max_plane_size(dev_priv, mode);
   450	}
   451	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux