Quoting Jani Nikula (2019-10-01 14:43:53) > Split out code related to vga client and vga switcheroo > register/unregister and state handling from i915_drv.c and > intel_display.c. > > It's a bit difficult to draw the line how much to move to the new file > from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo() > and i915_resume_switcheroo() in place was cleanest. > > No functional changes. > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > --- > > It's also a bit fuzzy if this is a sensible split anyway. Could also > name it intel_vga and move these from intel_display.c there? My initial thought that the switcheroo interface would remain in core, that it is more of a global power state that we currently just use for the legacy vga switching. The patch looks fine, on a pure mechanical pov, Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> For the sake of argument, could you float the split in the other direction? And maybe Ville has a good opinion on how it is meant to work :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
