Re: [PATCH] Make is_signed_type() simpler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 29 Sep 2019 23:06:19 +0300
Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> * Simply compare -1 with 0,
> * Drop unnecessary parenthesis sets
> 
> New macro leaves pointer as "unsigned type" but gives a warning,
> which should be fine because asking whether a pointer is signed is
> strange question.
> 
> I'm not sure what's going on in the i915 driver, it is shipping kernel
> pointers to userspace.

This tells us what the patch does, not why.

-- Steve

> 
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux