== Series Details == Series: series starting with [1/5] drm/i915: Switch intel_legacy_cursor_update() to intel_ types URL : https://patchwork.freedesktop.org/series/67337/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6e83c3bdcc40 drm/i915: Switch intel_legacy_cursor_update() to intel_ types 3cdcb4af301c drm/i915: Prepare the connector/encoder mask eadout for hw vs. uapi state split 4d9d48f0a291 drm/i915: Prepare the mode readout for hw vs. uapi state split cd2aa84c322f drm/i915: Add intel_atomic_crtc_state_for_each_plane_state() -:31: WARNING:LONG_LINE: line over 100 characters #31: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:451: + return to_intel_plane_state(state->base.planes[drm_plane_index(&plane->base)].state); -:67: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #67: FILE: drivers/gpu/drm/i915/display/intel_display.h:443: +#define intel_for_each_plane_mask(plane, dev, plane_mask) \ + list_for_each_entry((plane), &(dev)->mode_config.plane_list, base.head) \ + for_each_if ((plane_mask) & drm_plane_mask(&(plane)->base)) -:67: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #67: FILE: drivers/gpu/drm/i915/display/intel_display.h:443: +#define intel_for_each_plane_mask(plane, dev, plane_mask) \ + list_for_each_entry((plane), &(dev)->mode_config.plane_list, base.head) \ + for_each_if ((plane_mask) & drm_plane_mask(&(plane)->base)) -:69: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #69: FILE: drivers/gpu/drm/i915/display/intel_display.h:445: + for_each_if ((plane_mask) & drm_plane_mask(&(plane)->base)) -:71: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #71: FILE: drivers/gpu/drm/i915/display/intel_display.h:447: +#define intel_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state, state) \ + intel_for_each_plane_mask((plane), (state)->base.dev, (crtc_state)->base.plane_mask) \ + for_each_if (((plane_state) = \ + __intel_atomic_get_current_plane_state((state), (plane)))) -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.h:447: +#define intel_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state, state) \ + intel_for_each_plane_mask((plane), (state)->base.dev, (crtc_state)->base.plane_mask) \ + for_each_if (((plane_state) = \ + __intel_atomic_get_current_plane_state((state), (plane)))) -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.h:447: +#define intel_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state, state) \ + intel_for_each_plane_mask((plane), (state)->base.dev, (crtc_state)->base.plane_mask) \ + for_each_if (((plane_state) = \ + __intel_atomic_get_current_plane_state((state), (plane)))) -:73: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #73: FILE: drivers/gpu/drm/i915/display/intel_display.h:449: + for_each_if (((plane_state) = \ total: 2 errors, 3 warnings, 3 checks, 255 lines checked 7009d869fbe6 drm/i915: Add intel_atomic_add_affected_planes() -:47: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #47: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:469: + +} total: 0 errors, 0 warnings, 1 checks, 49 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx