On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj??l?? <ville.syrjala at linux.intel.com> > > Ringbuffer tail pointer must be qword aligned. Warn if someone > makes a mistake and forgets to pad the ring when the commands > inserted into the ring don't align to qword naturally. The assertion should be that we wrote precisely the number of dwords we declared in intel_ring_begin(). Which is one of the important factors to check whenever reviewing such code. This assertion (which should be a BUG_ON) is no substitute for such review. -Chris -- Chris Wilson, Intel Open Source Technology Centre