On Mon, Nov 26, 2012 at 1:48 PM, <ville.syrjala at linux.intel.com> wrote: > + /* tail must be qword aligned */ > + WARN_ON(ring->tail & 7); Minor bikeshed: Can you move the comment into the WARN argument so that if someone forgets to correctly pad stuff, dmesg will directly tell him wants wrong, instead of being forced to check the line numbers? Helps ridiculously lazy people like me ... ;-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
