Quoting Chris Wilson (2019-09-20 09:12:54) > Our sanitychecks indicate that while this register is context > saved/restore, the HW does not preserve this bit within the register -- > it likely doesn't exist, or one of those mythical bits that the > architects insist does something despite all appearances to the > contrary. > > For reference, SAMPLER_MODE is already in i915_reg.h as > GEN10_SAMPLER_MODE and is being setup in icl_ctx_workarounds_init() as > opposed to the chosen location here of rcs_engine_wa_init). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111754 > Fixes: 7f0cc34b5349 ("drm/i915/tgl: Implement Wa_1406941453") > Testcase: igt/i915_selftest/live_workarounds > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > Cc: Stuart Summers <stuart.summers@xxxxxxxxx> > Cc: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Lucas said last night in response to the CI error, "Yes, let's revert until I find out what I should really do." which I am going to take as a preemptive ack :) Acked-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
