Quoting Mika Kuoppala (2019-09-19 14:39:59)
> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
>
> > Quoting Mika Kuoppala (2019-09-19 13:57:45)
> >> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
> >> > + vma = i915_vma_instance(out, vm, NULL);
> >> > + if (IS_ERR(vma)) {
> >> > + err = PTR_ERR(vma);
> >> > + goto out_batch;
> >> > + }
> >> > +
> >> > + err = i915_vma_pin(vma, 0, 0,
> >> > + PIN_USER |
> >> > + PIN_OFFSET_FIXED |
> >> > + (vm->total - PAGE_SIZE));
> >> > + if (err)
> >> > + goto out_out;
> >>
> >> out_put?
> >
> > Joonas likes out: for normal exit paths that double for error handling.
>
> Ok. Fine with me. I just like the last part to describe what the first part
> of onion out does. Don't have to so much scroll back and forth
> in editor.
Oh, I didn't notice I had a typo. I thought it was out_put!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
