Quoting Chris Wilson (2019-09-18 11:47:49) > Quoting Tvrtko Ursulin (2019-09-18 11:26:57) > > > > On 18/09/2019 10:23, Chris Wilson wrote: > > > +static struct kobject * > > > +kobj_engine(struct kobject *dir, struct intel_engine_cs *engine) > > > +{ > > > + struct kobj_engine *ke; > > > + > > > + ke = kzalloc(sizeof(*ke), GFP_KERNEL); > > > + if (!ke) > > > + return NULL; > > > > Could embed kobj into the engine? > > My thinking was if we did that, the natural hierarchy would be > i915->gt->engine, and I wasn't ready to fully commit to that level of > detail. If we do add gt/ (and I hope we do), then engine/* can become symlinks. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx