Quoting Tvrtko Ursulin (2019-09-12 13:38:47) > > On 12/09/2019 12:32, Chris Wilson wrote: > > + if (val) > > + /* > > + * If we are coming back from being runtime suspended we must > > + * be careful not to report a larger value than returned > > + * previously. > > + */ > > The comment is a bit dislocated from the logic so feels it would better > go into __pmu_update_rc6. > > > + val = __pmu_update_rc6(pmu, val); > > + else > > + /* > > + * We were runtime suspended. > > s/were/are/, or maybe it is "think we are". :) "We think we are" captures my anxiety. Moving both into their respective routines. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx