== Series Details == Series: series starting with [CI,01/13] drm/i915: introduce a mechanism to extend execbuf2 URL : https://patchwork.freedesktop.org/series/66418/ State : warning == Summary == $ dim checkpatch origin/drm-tip 66b565b57b3f drm/i915: introduce a mechanism to extend execbuf2 -:141: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #141: FILE: include/uapi/drm/i915_drm.h:1165: +#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_USE_EXTENSIONS<<1)) ^ total: 0 errors, 0 warnings, 1 checks, 113 lines checked 503c88dc3bc0 drm/i915: add syncobj timeline support -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #25: https://lists.freedesktop.org/archives/dri-devel/2019-August/229287.html -:381: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'? #381: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2616: + * The chain's ownership is transfered to the -:412: ERROR:CODE_INDENT: code indent should use tabs where possible #412: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2647: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ -:412: WARNING:LEADING_SPACE: please, no spaces at the start of a line #412: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2647: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ total: 1 errors, 3 warnings, 0 checks, 541 lines checked 66b65143aa4d drm/i915/perf: drop list of streams 8aca4673ec28 drm/i915/perf: store the associated engine of a stream 8db92539084e drm/i915/perf: introduce a versioning of the i915-perf uapi 8bb8be52ca97 drm/i915/perf: move perf types to their own header -:342: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #342: new file mode 100644 -:347: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #347: FILE: drivers/gpu/drm/i915/i915_perf_types.h:1: +/* -:348: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #348: FILE: drivers/gpu/drm/i915/i915_perf_types.h:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 648 lines checked da1c41cf2065 drm/i915/perf: allow for CS OA configs to be created lazily -:103: CHECK:SPACING: No space is necessary after a cast #103: FILE: drivers/gpu/drm/i915/i915_perf.c:399: + (u32) MI_LOAD_REGISTER_IMM_MAX_REGS); -:118: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #118: FILE: drivers/gpu/drm/i915/i915_perf.c:410: +static struct i915_oa_config_bo* alloc_oa_config_buffer(struct drm_i915_private *i915, total: 1 errors, 0 warnings, 1 checks, 507 lines checked 4ef9530de87e drm/i915/perf: implement active wait for noa configurations -:43: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #43: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:242: +#define MI_MATH(x) MI_INSTR(0x1a, (x)-1) ^ -:122: CHECK:LINE_SPACING: Please don't use multiple blank lines #122: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3610: + + -:181: CHECK:LINE_SPACING: Please don't use multiple blank lines #181: FILE: drivers/gpu/drm/i915/i915_perf.c:460: + -:234: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #234: FILE: drivers/gpu/drm/i915/i915_perf.c:1758: + uint32_t d; -:260: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #260: FILE: drivers/gpu/drm/i915/i915_perf.c:1784: + DIV64_U64_ROUND_UP( -:285: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #285: FILE: drivers/gpu/drm/i915/i915_perf.c:1809: + batch = cs = i915_gem_object_pin_map(bo, I915_MAP_WB); -:293: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #293: FILE: drivers/gpu/drm/i915/i915_perf.c:1817: + cs = save_restore_register( -:297: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #297: FILE: drivers/gpu/drm/i915/i915_perf.c:1821: + cs = save_restore_register( -:397: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #397: FILE: drivers/gpu/drm/i915/i915_perf.c:1921: + cs = save_restore_register( -:401: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #401: FILE: drivers/gpu/drm/i915/i915_perf.c:1925: + cs = save_restore_register( total: 0 errors, 0 warnings, 10 checks, 420 lines checked 0432b1e0d15d drm/i915: add wait flags to i915_active_request_retire 647d2458b7c3 drm/i915/perf: execute OA configuration from command stream -:66: CHECK:LINE_SPACING: Please don't use multiple blank lines #66: FILE: drivers/gpu/drm/i915/i915_perf.c:1577: + + total: 0 errors, 0 warnings, 1 checks, 311 lines checked 8a629929451c drm/i915: add a new perf configuration execbuf parameter -:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #27: v7: Hold drm.struct_mutex when serializing the request with OA config (Chris) -:67: CHECK:LINE_SPACING: Please don't use multiple blank lines #67: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1161: + -:100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #100: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1194: + err = i915_perf_get_oa_config_and_bo( -:153: WARNING:LONG_LINE_COMMENT: line over 100 characters #153: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2139: + err = i915_request_await_object(eb->request, eb->oa_vma->obj, false); /* await_resv already! */ -:210: ERROR:CODE_INDENT: code indent should use tabs where possible #210: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2774: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ -:210: WARNING:LEADING_SPACE: please, no spaces at the start of a line #210: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2774: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ total: 1 errors, 3 warnings, 2 checks, 273 lines checked fc2e0e5e7126 drm/i915/perf: allow holding preemption on filtered ctx -:105: WARNING:BRACES: braces {} are not necessary for single statement blocks #105: FILE: drivers/gpu/drm/i915/i915_perf.c:3222: + if (IS_HASWELL(dev_priv) && specific_ctx && !props->hold_preemption) { privileged_op = false; + } total: 0 errors, 1 warnings, 0 checks, 123 lines checked 668a68776edd drm/i915: add support for perf configuration queries -:190: WARNING:BRACES: braces {} are not necessary for single statement blocks #190: FILE: drivers/gpu/drm/i915/i915_query.c:248: + if (__get_user(config_id, &user_query_config_ptr->config)) { + return -EFAULT; + } total: 0 errors, 1 warnings, 0 checks, 417 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx