Re: [PATCH 1/2] drm/i915: Use engine relative LRIs on context setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Mika Kuoppala (2019-09-06 14:31:45)
> @@ -2939,6 +2942,10 @@ void intel_execlists_set_default_submission(struct intel_engine_cs *engine)
>                 if (HAS_LOGICAL_RING_PREEMPTION(engine->i915))
>                         engine->flags |= I915_ENGINE_HAS_PREEMPTION;
>         }
> +
> +       engine->flags |= (engine->class != COPY_ENGINE_CLASS &&
> +                         INTEL_GEN(engine->i915) >= 12) ?
> +               I915_ENGINE_HAS_RELATIVE_MMIO : 0;

Style nit, I would have stuck with a plain
	if (class != COPY && GEN >= 12)
		engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO;

The flag takes care of the virtual engine switching nicely.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux