== Series Details == Series: Send a hotplug when edid changes (rev7) URL : https://patchwork.freedesktop.org/series/62816/ State : warning == Summary == $ dim checkpatch origin/drm-tip c2072e1d23ff drm: Add helper to compare edids. -:32: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid1" #32: FILE: drivers/gpu/drm/drm_edid.c:1375: + bool edid1_present = edid1 != NULL; -:33: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid2" #33: FILE: drivers/gpu/drm/drm_edid.c:1376: + bool edid2_present = edid2 != NULL; -:39: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #39: FILE: drivers/gpu/drm/drm_edid.c:1382: + if (edid1) { + -:54: CHECK:LINE_SPACING: Please don't use multiple blank lines #54: FILE: drivers/gpu/drm/drm_edid.c:1397: + + total: 0 errors, 0 warnings, 4 checks, 54 lines checked 701f9863dd56 drm: Introduce epoch counter to drm_connector -:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #55: FILE: drivers/gpu/drm/drm_connector.c:1897: + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Edid was changed.\n", + connector->base.id, connector->name); -:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #59: FILE: drivers/gpu/drm/drm_connector.c:1901: + DRM_DEBUG_KMS("Updating change counter to %llu\n", + connector->epoch_counter); -:119: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #119: FILE: drivers/gpu/drm/drm_probe_helper.c:788: + uint64_t old_epoch_counter; -:150: WARNING:BRACES: braces {} are not necessary for single statement blocks #150: FILE: drivers/gpu/drm/drm_probe_helper.c:824: + if (old_epoch_counter != connector->epoch_counter) { changed = true; + } -:174: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #174: FILE: include/drm/drm_connector.h:1292: + uint64_t epoch_counter; total: 0 errors, 1 warnings, 4 checks, 128 lines checked 610c89a4b314 drm/i915: Send hotplug event if edid had changed -:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #61: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:299: + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s(epoch counter %llu)\n", connector->base.base.id, total: 0 errors, 0 warnings, 1 checks, 36 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx