== Series Details == Series: Send a hotplug when edid changes (rev6) URL : https://patchwork.freedesktop.org/series/62816/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1b3a1a6c8669 drm: Add helper to compare edids. -:32: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid1" #32: FILE: drivers/gpu/drm/drm_edid.c:1375: + bool edid1_present = edid1 != NULL; -:33: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "edid2" #33: FILE: drivers/gpu/drm/drm_edid.c:1376: + bool edid2_present = edid2 != NULL; -:39: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #39: FILE: drivers/gpu/drm/drm_edid.c:1382: + if (edid1) { + -:54: CHECK:LINE_SPACING: Please don't use multiple blank lines #54: FILE: drivers/gpu/drm/drm_edid.c:1397: + + total: 0 errors, 0 warnings, 4 checks, 54 lines checked 938f585a15c0 drm: Introduce change counter to drm_connector -:42: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #42: FILE: drivers/gpu/drm/drm_probe_helper.c:780: + uint64_t old_epoch_counter; -:69: WARNING:BRACES: braces {} are not necessary for single statement blocks #69: FILE: drivers/gpu/drm/drm_probe_helper.c:812: + if (old_status != connector->status) { changed = true; + } -:102: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #102: FILE: include/drm/drm_connector.h:1292: + uint64_t epoch_counter; total: 0 errors, 1 warnings, 2 checks, 69 lines checked 81f0e42eda4c drm/i915: Send hotplug event if edid had changed. -:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #8: to calling layer using drm_connector->change_counter(proposed by Daniel Vetter). -:63: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #63: FILE: drivers/gpu/drm/drm_connector.c:1897: + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Edid was changed.\n", + connector->base.id, connector->name); -:67: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #67: FILE: drivers/gpu/drm/drm_connector.c:1901: + DRM_DEBUG_KMS("Updating change counter to %llu\n", + connector->epoch_counter); -:141: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #141: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:302: + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s(change counter %llu)\n", connector->base.base.id, total: 0 errors, 1 warnings, 3 checks, 99 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
