== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev14) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 122b0ae456db drm/i915/display: Add func to get gamma bit precision ad9f91835ee7 drm/i915/display: Add debug log for color parameters 8352876a8f80 drm/i915/display: Add func to compare hw/sw gamma lut 6206ac8d1f9c drm/i915/display: Add macro to compare gamma hw/sw lut -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name1' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12686: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name1' may be better as '(name1)' to avoid precedence issues #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12686: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name2' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12686: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name2' may be better as '(name2)' to avoid precedence issues #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12686: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) total: 0 errors, 0 warnings, 4 checks, 49 lines checked 0ee282955ff1 drm/i915/display: Extract i9xx_read_luts() -:71: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #71: FILE: drivers/gpu/drm/i915/display/intel_color.c:1543: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:73: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #73: FILE: drivers/gpu/drm/i915/display/intel_color.c:1545: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:75: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #75: FILE: drivers/gpu/drm/i915/display/intel_color.c:1547: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( total: 0 errors, 0 warnings, 3 checks, 75 lines checked aac65c8c33e5 drm/i915/display: Extract ilk_read_luts() -:54: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #54: FILE: drivers/gpu/drm/i915/display/intel_color.c:1581: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:56: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #56: FILE: drivers/gpu/drm/i915/display/intel_color.c:1583: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:58: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #58: FILE: drivers/gpu/drm/i915/display/intel_color.c:1585: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( -:81: CHECK:BRACES: Unbalanced braces around else statement #81: FILE: drivers/gpu/drm/i915/display/intel_color.c:1647: + else { total: 0 errors, 0 warnings, 4 checks, 67 lines checked 51f505e22c73 drm/i915/display: Extract glk_read_luts() -:54: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #54: FILE: drivers/gpu/drm/i915/display/intel_color.c:1625: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:56: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #56: FILE: drivers/gpu/drm/i915/display/intel_color.c:1627: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:58: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #58: FILE: drivers/gpu/drm/i915/display/intel_color.c:1629: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( total: 0 errors, 0 warnings, 3 checks, 73 lines checked b2aefcd3a19b FOR_TESTING_ONLY: Print rgb values of hw and sw blobs -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:16: WARNING:LONG_LINE: line over 100 characters #16: FILE: drivers/gpu/drm/i915/display/intel_color.c:1437: + DRM_DEBUG_KMS("hw_lut->red=0x%x sw_lut->red=0x%x hw_lut->blue=0x%x sw_lut->blue=0x%x hw_lut->green=0x%x sw_lut->green=0x%x", lut2->red, lut1->red, lut2->blue, lut1->blue, lut2->green, lut1->green); total: 0 errors, 2 warnings, 0 checks, 8 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
