== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev13) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 329aa0177067 drm/i915/display: Add func to get gamma bit precision b39c8ce28cc7 drm/i915/display: Add debug log for color parameters a66c08206a9b drm/i915/display: Add func to compare hw/sw gamma lut -:108: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sw_lut_size != 262145' #108: FILE: drivers/gpu/drm/i915/display/intel_color.c:1544: + if ((sw_lut_size != 262145) || (hw_lut_size != 521)) -:108: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw_lut_size != 521' #108: FILE: drivers/gpu/drm/i915/display/intel_color.c:1544: + if ((sw_lut_size != 262145) || (hw_lut_size != 521)) total: 0 errors, 0 warnings, 2 checks, 129 lines checked b82a8dde760e drm/i915/display: Add macro to compare gamma hw/sw lut -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name1' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name1' may be better as '(name1)' to avoid precedence issues #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name2' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name2' may be better as '(name2)' to avoid precedence issues #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) total: 0 errors, 0 warnings, 4 checks, 49 lines checked 6821749514aa drm/i915/display: Extract i9xx_read_luts() -:69: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #69: FILE: drivers/gpu/drm/i915/display/intel_color.c:1614: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:71: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #71: FILE: drivers/gpu/drm/i915/display/intel_color.c:1616: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:73: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #73: FILE: drivers/gpu/drm/i915/display/intel_color.c:1618: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( total: 0 errors, 0 warnings, 3 checks, 75 lines checked 0e30173fca80 drm/i915/display: Extract i965_read_luts() -:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #19: -Renamed i965_read_gamma_lut_10p6() to i965_read_lut_10p6() [Ville, Uma] total: 0 errors, 1 warnings, 0 checks, 64 lines checked 392f6c41e8aa drm/i915/display: Extract chv_read_luts() -:53: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #53: FILE: drivers/gpu/drm/i915/display/intel_color.c:1693: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:55: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #55: FILE: drivers/gpu/drm/i915/display/intel_color.c:1695: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( -:59: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #59: FILE: drivers/gpu/drm/i915/display/intel_color.c:1699: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( total: 0 errors, 0 warnings, 3 checks, 64 lines checked bc148699e793 drm/i915/display: Extract ilk_read_luts() -:51: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #51: FILE: drivers/gpu/drm/i915/display/intel_color.c:1736: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:53: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #53: FILE: drivers/gpu/drm/i915/display/intel_color.c:1738: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:55: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #55: FILE: drivers/gpu/drm/i915/display/intel_color.c:1740: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( -:78: CHECK:BRACES: Unbalanced braces around else statement #78: FILE: drivers/gpu/drm/i915/display/intel_color.c:1804: + else { total: 0 errors, 0 warnings, 4 checks, 67 lines checked f1edfeae6b32 drm/i915/display: Extract glk_read_luts() -:54: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #54: FILE: drivers/gpu/drm/i915/display/intel_color.c:1780: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( -:56: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #56: FILE: drivers/gpu/drm/i915/display/intel_color.c:1782: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( -:58: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #58: FILE: drivers/gpu/drm/i915/display/intel_color.c:1784: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( total: 0 errors, 0 warnings, 3 checks, 73 lines checked ccb2fd7e595f drm/i915/display: Extract icl_read_luts() -:94: WARNING:LONG_LINE: line over 100 characters #94: FILE: drivers/gpu/drm/i915/display/intel_color.c:1839: + blob_data[i + 8].green = REG_FIELD_GET(PAL_PREC_MULTI_SEG_GREEN_LDW_MASK, val1) << 10 | -:96: WARNING:LONG_LINE: line over 100 characters #96: FILE: drivers/gpu/drm/i915/display/intel_color.c:1841: + blob_data[i + 8].blue = REG_FIELD_GET(PAL_PREC_MULTI_SEG_BLUE_LDW_MASK, val1) << 10 | -:104: WARNING:LONG_LINE: line over 100 characters #104: FILE: drivers/gpu/drm/i915/display/intel_color.c:1849: + blob_data[i + 265].red = REG_FIELD_GET(PAL_PREC_MULTI_SEG_RED_LDW_MASK, val1) << 10 | -:106: WARNING:LONG_LINE: line over 100 characters #106: FILE: drivers/gpu/drm/i915/display/intel_color.c:1851: + blob_data[i + 265].green = REG_FIELD_GET(PAL_PREC_MULTI_SEG_GREEN_LDW_MASK, val1) << 10 | -:108: WARNING:LONG_LINE: line over 100 characters #108: FILE: drivers/gpu/drm/i915/display/intel_color.c:1853: + blob_data[i + 265].blue = REG_FIELD_GET(PAL_PREC_MULTI_SEG_BLUE_LDW_MASK, val1) << 10 | total: 0 errors, 5 warnings, 0 checks, 133 lines checked 324b6c5f95e6 FOR_TESTING_ONLY: Print rgb values of hw and sw blobs -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:16: WARNING:LONG_LINE: line over 100 characters #16: FILE: drivers/gpu/drm/i915/display/intel_color.c:1473: + DRM_DEBUG_KMS("hw_lut->red=0x%x sw_lut->red=0x%x hw_lut->blue=0x%x sw_lut->blue=0x%x hw_lut->green=0x%x sw_lut->green=0x%x", hw_lut->red, sw_lut->red, hw_lut->blue, sw_lut->blue, hw_lut->green, sw_lut->green); total: 0 errors, 2 warnings, 0 checks, 8 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
