== Series Details == Series: drm/i915: adding state checker for gamma lut value URL : https://patchwork.freedesktop.org/series/65784/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2922e0d8ceeb drm/i915/display: Add func to get gamma bit precision 766a11160765 drm/i915/display: Add debug log for color parameters -:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #21: FILE: drivers/gpu/drm/i915/display/intel_display.c:12143: + DRM_DEBUG_KMS("cgm_mode:%d gamma_mode:%d gamma_enable:%d csc_enable:%d\n", + pipe_config->cgm_mode, pipe_config->gamma_mode, -:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #25: FILE: drivers/gpu/drm/i915/display/intel_display.c:12147: + DRM_DEBUG_KMS("csc_mode:%d gamma_mode:%d gamma_enable:%d csc_enable:%d\n", + pipe_config->csc_mode, pipe_config->gamma_mode, total: 0 errors, 0 warnings, 2 checks, 15 lines checked 659b0a1d2d40 drm/i915/display: Add func to compare hw/sw gamma lut -:7: WARNING:TYPO_SPELLING: 'comparsion' may be misspelled - perhaps 'comparison'? #7: lut values. Since hw/sw gamma lut sizes and lut enteries comparsion -:65: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #65: FILE: drivers/gpu/drm/i915/display/intel_color.c:1497: + return false; + else -:80: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #80: FILE: drivers/gpu/drm/i915/display/intel_color.c:1512: + if (!intel_color_lut_entry_equal(sw_lut, hw_lut, hw_lut_size, err)) + return false; -:82: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #82: FILE: drivers/gpu/drm/i915/display/intel_color.c:1514: + else + break; total: 0 errors, 4 warnings, 0 checks, 96 lines checked 76cee29da173 drm/i915/display: Add macro to compare gamma hw/sw lut -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name1' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:29: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name1' may be better as '(name1)' to avoid precedence issues #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name2' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) -:29: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name2' may be better as '(name2)' to avoid precedence issues #29: FILE: drivers/gpu/drm/i915/display/intel_display.c:12684: +#define PIPE_CONF_CHECK_COLOR_LUT(name1, name2, bit_precision) do { \ + if (current_config->name1 != pipe_config->name1) { \ + pipe_config_mismatch(fastset, __stringify(name1), \ + "(expected %i, found %i, won't compare lut values)\n", \ + current_config->name1, \ + pipe_config->name1); \ + ret = false;\ + } else { \ + if (!intel_color_lut_equal(current_config->name2, \ + pipe_config->name2, pipe_config->name1, \ + bit_precision)) { \ + pipe_config_mismatch(fastset, __stringify(name2), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ + } \ +} while (0) total: 0 errors, 0 warnings, 4 checks, 49 lines checked 2dbaebe31071 drm/i915/display: Extract i9xx_read_luts() -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: lut values. Also, add function intel_color_lut_pack to convert hw value with -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/display/intel_color.c:1561: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_RED_MASK, val), 8); -:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/display/intel_color.c:1562: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_GREEN_MASK, val), 8); -:59: WARNING:LONG_LINE: line over 100 characters #59: FILE: drivers/gpu/drm/i915/display/intel_color.c:1563: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_BLUE_MASK, val), 8); total: 0 errors, 4 warnings, 0 checks, 72 lines checked 615f1d72ea29 drm/i91/display: Extract i965_read_luts() -:41: WARNING:LONG_LINE: line over 100 characters #41: FILE: drivers/gpu/drm/i915/display/intel_color.c:1596: + blob_data[i].red = REG_FIELD_GET(PALETTE_RED_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_RED_MASK, val2); -:42: WARNING:LONG_LINE: line over 100 characters #42: FILE: drivers/gpu/drm/i915/display/intel_color.c:1597: + blob_data[i].green = REG_FIELD_GET(PALETTE_GREEN_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_GREEN_MASK, val2); -:43: WARNING:LONG_LINE: line over 100 characters #43: FILE: drivers/gpu/drm/i915/display/intel_color.c:1598: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; -:43: WARNING:SPACING: space prohibited before semicolon #43: FILE: drivers/gpu/drm/i915/display/intel_color.c:1598: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; total: 0 errors, 4 warnings, 0 checks, 60 lines checked f27642b0cd05 drm/i915/display: Extract chv_read_luts() -:39: WARNING:LONG_LINE: line over 100 characters #39: FILE: drivers/gpu/drm/i915/display/intel_color.c:1632: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_GREEN_MASK, val), 10); -:40: WARNING:LONG_LINE: line over 100 characters #40: FILE: drivers/gpu/drm/i915/display/intel_color.c:1633: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_BLUE_MASK, val), 10); -:43: WARNING:LONG_LINE: line over 100 characters #43: FILE: drivers/gpu/drm/i915/display/intel_color.c:1636: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_RED_MASK, val), 10); total: 0 errors, 3 warnings, 0 checks, 60 lines checked 5540e8e48bdc drm/i915/display: Extract ilk_read_luts() -:40: WARNING:LONG_LINE: line over 100 characters #40: FILE: drivers/gpu/drm/i915/display/intel_color.c:1671: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_RED_MASK, val), 10); -:41: WARNING:LONG_LINE: line over 100 characters #41: FILE: drivers/gpu/drm/i915/display/intel_color.c:1672: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_GREEN_MASK, val), 10); -:42: WARNING:LONG_LINE: line over 100 characters #42: FILE: drivers/gpu/drm/i915/display/intel_color.c:1673: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_BLUE_MASK, val), 10); -:64: CHECK:BRACES: Unbalanced braces around else statement #64: FILE: drivers/gpu/drm/i915/display/intel_color.c:1736: + else { total: 0 errors, 3 warnings, 1 checks, 63 lines checked 0ffafe03ab60 drm/i915/display: Extract glk_read_luts() -:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/display/intel_color.c:1712: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_RED_MASK, val), 10); -:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/display/intel_color.c:1713: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_GREEN_MASK, val), 10); -:46: WARNING:LONG_LINE: line over 100 characters #46: FILE: drivers/gpu/drm/i915/display/intel_color.c:1714: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_BLUE_MASK, val), 10); total: 0 errors, 3 warnings, 0 checks, 70 lines checked d185e0dd059f FOR_TESTING_ONLY: Print rgb values of hw and sw blobs -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:16: WARNING:LONG_LINE: line over 100 characters #16: FILE: drivers/gpu/drm/i915/display/intel_color.c:1456: + DRM_DEBUG_KMS("hw_lut->red=0x%x sw_lut->red=0x%x hw_lut->blue=0x%x sw_lut->blue=0x%x hw_lut->green=0x%x sw_lut->green=0x%x", hw_lut->red, sw_lut->red, hw_lut->blue, sw_lut->blue, hw_lut->green, sw_lut->green); total: 0 errors, 2 warnings, 0 checks, 8 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
