== Series Details == Series: series starting with drm/i915: Switch obj->mm.lock lockdep annotations on its head (rev2) URL : https://patchwork.freedesktop.org/series/65467/ State : warning == Summary == $ dim checkpatch origin/drm-tip 93bdacc163d4 drm/i915: Switch obj->mm.lock lockdep annotations on its head -:118: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #118: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:287: + * struct_mutex in the entire system. */ -:308: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 188 lines checked 3f6e434b7d4d lockdep: add might_lock_nested() -:23: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #23: FILE: include/linux/lockdep.h:634: +# define might_lock_nested(lock, subclass) ^I^I^I^I\$ -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lock' - possible side-effects? #23: FILE: include/linux/lockdep.h:634: +# define might_lock_nested(lock, subclass) \ +do { \ + typecheck(struct lockdep_map *, &(lock)->dep_map); \ + lock_acquire(&(lock)->dep_map, subclass, 0, 1, 1, NULL, \ + _THIS_IP_); \ + lock_release(&(lock)->dep_map, 0, _THIS_IP_); \ +} while (0) -:40: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 1 checks, 20 lines checked 7dd9716d5f40 drm/i915: use might_lock_nested in get_pages annotation -:37: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #37: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:241: + * struct_mutex in the entire system. */ -:78: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 49 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
