Re: [PATCH 02/10] drm/i915: Generalise the clflush dma-worker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Matthew Auld (2019-08-19 19:16:20)
> On Mon, 19 Aug 2019 at 17:45, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Extract the dma-fence worker used by clflush for wider use, as we
> > anticipate using workers coupled to dma-fences more frequently.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> 
> <snip>
> 
> > +
> > +static const char *get_timeline_name(struct dma_fence *fence)
> > +{
> > +       return "work";
> > +}
> 
> work->name, or not all that useful for debug?

Hmm. work->name feels like overkill. If we could "%pS" work->fn...

That turns out to kallsyms_lookup(), but it takes a namebuf.

With two function pointers, I was thinking we should move to a const
vfunc table, given the various issues with overwriting function points.
We can throw a name in there.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux