== Series Details == Series: series starting with [1/6] dma-buf: Introduce selftesting framework (rev3) URL : https://patchwork.freedesktop.org/series/65353/ State : warning == Summary == $ dim checkpatch origin/drm-tip e16973981faa dma-buf: Introduce selftesting framework -:27: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #27: FILE: drivers/dma-buf/Kconfig:42: +config DMABUF_SELFTESTS -:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 -:50: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/dma-buf/selftest.c', please use '//' instead #50: FILE: drivers/dma-buf/selftest.c:1: +/* SPDX-License-Identifier: MIT */ -:50: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #50: FILE: drivers/dma-buf/selftest.c:1: +/* SPDX-License-Identifier: MIT */ -:70: ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #70: FILE: drivers/dma-buf/selftest.c:21: +#define selftest(n, f) [__idx_##n] = { .name = #n, .func = f }, -:78: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #78: FILE: drivers/dma-buf/selftest.c:29: +}; +#undef selftest -:82: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #82: FILE: drivers/dma-buf/selftest.c:33: +#define selftest_0(n, func, id) \ +module_param_named(id, selftests[__idx_##n].enabled, bool, 0400); -:84: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #84: FILE: drivers/dma-buf/selftest.c:35: +#define selftest(n, func) selftest_0(n, func, param(n)) -:223: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/dma-buf/selftest.h', please use '/*' instead #223: FILE: drivers/dma-buf/selftest.h:1: +// SPDX-License-Identifier: MIT -:223: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #223: FILE: drivers/dma-buf/selftest.h:1: +// SPDX-License-Identifier: MIT -:234: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #234: FILE: drivers/dma-buf/selftest.h:12: +#define selftest(name, func) int func(void); -:247: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'T' - possible side-effects? #247: FILE: drivers/dma-buf/selftest.h:25: +#define subtests(T, data) \ + __subtests(__func__, T, ARRAY_SIZE(T), data) total: 1 errors, 8 warnings, 3 checks, 224 lines checked 7fddd1caea50 dma-buf: Add selftests for dma-fence -:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 -:40: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/dma-buf/st-dma-fence.c', please use '//' instead #40: FILE: drivers/dma-buf/st-dma-fence.c:1: +/* SPDX-License-Identifier: MIT */ -:40: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #40: FILE: drivers/dma-buf/st-dma-fence.c:1: +/* SPDX-License-Identifier: MIT */ -:60: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t #60: FILE: drivers/dma-buf/st-dma-fence.c:21: + struct spinlock lock; -:192: WARNING:MEMORY_BARRIER: memory barrier without comment #192: FILE: drivers/dma-buf/st-dma-fence.c:153: + smp_store_mb(container_of(cb, struct simple_cb, cb)->seen, true); -:500: WARNING:MEMORY_BARRIER: memory barrier without comment #500: FILE: drivers/dma-buf/st-dma-fence.c:461: + smp_wmb(); -:511: WARNING:MEMORY_BARRIER: memory barrier without comment #511: FILE: drivers/dma-buf/st-dma-fence.c:472: + smp_store_mb(cb.seen, false); -:534: WARNING:MEMORY_BARRIER: memory barrier without comment #534: FILE: drivers/dma-buf/st-dma-fence.c:495: + smp_wmb(); -:599: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'dma_fence', this function's name, in a string #599: FILE: drivers/dma-buf/st-dma-fence.c:560: + pr_info("sizeof(dma_fence)=%lu\n", sizeof(struct dma_fence)); total: 0 errors, 9 warnings, 0 checks, 584 lines checked 193bf5443d1e dma-fence: Shrink size of struct dma_fence -:27: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #27: FILE: include/linux/dma-fence.h:66: + spinlock_t *lock; total: 0 errors, 0 warnings, 1 checks, 21 lines checked c7c0ee948b31 dma-fence: Avoid list_del during fence->cb_list iteration 1de075a7a6cb dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal 3105c8cfc60f dma-fence: Store the timestamp in the same union as the cb_list _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
