Quoting Michal Wajdeczko (2019-08-16 18:51:30) > We really need to have separate NOT_SUPPORTED state (for > lack of hardware support) and DISABLED state (to indicate > user decision) as we will have to take special steps even > if GuC firmware is now disabled but hardware exists and > could have been previously used. Could you give a quick run down on the transition points? driver_probe -> UNINIT uc_probe -> SUPPORTS uc_init -> ENABLED > static inline bool intel_guc_is_supported(struct intel_guc *guc) > { > - return intel_uc_fw_supported(&guc->fw); > + return intel_uc_fw_is_supported(&guc->fw); > +} > + > +static inline bool intel_guc_is_enabled(struct intel_guc *guc) > +{ > + return intel_uc_fw_is_enabled(&guc->fw); > } and include it somewhere around here? I'm finding that overview hard to put together from the patch context. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx