On 8/16/19 2:40 AM, Michal Wajdeczko wrote:
On Fri, 16 Aug 2019 03:23:42 +0200, Daniele Ceraolo Spurio
<daniele.ceraolospurio@xxxxxxxxx> wrote:
With the introduction of display uncore, we want to categorize registers
between display and non-display. To help us getting it right, it will
be useful to move the display registers to a new file that can be used
without including i915_reg.h. To allow that, move all the basic register
type definitions and helpers to i915_reg_types.h and include that
instead of i915_reg.h from header files in the driver. We'll then
be able to replace i915_reg.h with the new display-only header in
display files and make sure the registers are correctly
compartmentalized.
maybe this split should another way:
i915_reg.h = basic typedefs and macros
intel_reg.h = register definitions
and
intel_display_reg.h = display related regs (your goal)
intel_guc_reg.h = GuC related regs (we already have that!)
then we follow the rule to use i915_ prefix for driver specific
code and intel_ prefix for hardware originated definitions
Around the code we're using the *_types.h format for the headers with
the basic defs, so I'd prefer to stick with that. But I can go with
intel_* prefix and rename i915_reg.h to intel_reg.h.
Daniele
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
