Quoting Mika Kuoppala (2019-08-16 13:02:21) > > diff --git a/drivers/gpu/drm/i915/i915_active_types.h b/drivers/gpu/drm/i915/i915_active_types.h > > index ae3ee441c114..d857bd12aa7e 100644 > > --- a/drivers/gpu/drm/i915/i915_active_types.h > > +++ b/drivers/gpu/drm/i915/i915_active_types.h > > @@ -24,6 +24,9 @@ struct i915_active_request { > > struct i915_request __rcu *request; > > struct list_head link; > > i915_active_retire_fn retire; > > +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) > > + struct mutex *lock; > > Checkpatch thinks the usage should be somehow stated with comment. > > So put something like > /* Incorporeal. Ref piggypacking timeline for lockdep */ I'm using incorporeal. :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx