Re: [PATCH v2] drm/i915: Disregard drm_mode_config.fb_base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Srivatsa, Anusha (2019-08-14 00:41:15)
> 
> 
> > -----Original Message-----
> > From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Sent: Tuesday, August 13, 2019 11:21 AM
> > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; Daniel Vetter
> > <daniel.vetter@xxxxxxxx>; Maarten Lankhorst
> > <maarten.lankhorst@xxxxxxxxxxxxxxx>; Srivatsa, Anusha
> > <anusha.srivatsa@xxxxxxxxx>
> > Subject: [PATCH v2] drm/i915: Disregard drm_mode_config.fb_base
> > 
> > The fb_base is only used for communicating the GTT BAR from one piece of the
> > display code (kms setup) to another (fbdev). What is required in the fbdev is just
> > the aperture address which should be derived from the bo we allocate for the
> > framebuffer directly.
> > 
> > The same appears true for drm/; it is not used by the core or the uAPI, it is
> > merely for conveniently passing a device address from bit of display
> > management code to another.
> > 
> > v2: Note that since we only expose enough of a system map to cover our single
> > framebuffer, the screen_base/size and the smem are one and the same.
> > 
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> 
> Reviewed-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>

Plonked it in as I hope it stands it stead as a nice little
simplification.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux