Re: [PATCH] drm/i915/guc: Remove client->submissions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2019-08-14 09:00:18)
> Quoting Daniele Ceraolo Spurio (2019-08-14 01:21:45)
> > The engine->guc_id is GuC FW defined and it is not guaranteed to be
> > below I915_NUM_ENGINES, so we shouldn't use it with the i915-defined
> > client->submissions, as we might overflow.
> > Instead of fixing it, just get rid of client->submissions, because the
> > information we get from it is not interesting anymore now that we only
> > have 1 client.
> 
> It was ever useful? Umpteen billion submissions here, umpteen billion
> submissions there. Or the other extreme, 1. No more, no less :)
>  
> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

And pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux