Quoting Michal Wajdeczko (2019-08-12 08:39:49) > After successful uC initialization we are reporting GuC > firmware version and status of GuC submission and HuC. > Add HuC fw version to this report to make it complete, > but also skip all HuC info if HuC is not supported. > > v2: squeeze to one line (Chris) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > index aa9701cfc754..a3a5918c6782 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > @@ -503,12 +503,20 @@ int intel_uc_init_hw(struct intel_uc *uc) > goto err_communication; > } > > - dev_info(i915->drm.dev, "GuC firmware version %u.%u\n", > - guc->fw.major_ver_found, guc->fw.minor_ver_found); > - dev_info(i915->drm.dev, "GuC submission %s\n", > + dev_info(i915->drm.dev, "%s firmware %s version %u.%u %s:%s\n", I would have put a comma between the version and the tag:state. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
