Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
> As we are phasing out using the GEM context for internal clients that
> need to manipulate logical context state directly, remove the
> constructor for the GVT context. We are not using it for anything other
> than default setup and allocation of an i915_ppgtt.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Not familiar with gvt but seems to create similar enough
context.
Higher priority, not closed and using more strict
lock.
As discussed in irc, closed is for execbuf verification
so we won't be gaining any warning coverage.
Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 47 ---------------------
> drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 -
> drivers/gpu/drm/i915/gvt/scheduler.c | 22 +++++++---
> 3 files changed, 17 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index b407baaf0014..afd994391ad7 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -529,53 +529,6 @@ i915_gem_create_context(struct drm_i915_private *dev_priv, unsigned int flags)
> return ctx;
> }
>
> -/**
> - * i915_gem_context_create_gvt - create a GVT GEM context
> - * @dev: drm device *
> - *
> - * This function is used to create a GVT specific GEM context.
> - *
> - * Returns:
> - * pointer to i915_gem_context on success, error pointer if failed
> - *
> - */
> -struct i915_gem_context *
> -i915_gem_context_create_gvt(struct drm_device *dev)
> -{
> - struct i915_gem_context *ctx;
> - int ret;
> -
> - if (!IS_ENABLED(CONFIG_DRM_I915_GVT))
> - return ERR_PTR(-ENODEV);
> -
> - ret = i915_mutex_lock_interruptible(dev);
> - if (ret)
> - return ERR_PTR(ret);
> -
> - ctx = i915_gem_create_context(to_i915(dev), 0);
> - if (IS_ERR(ctx))
> - goto out;
> -
> - ret = i915_gem_context_pin_hw_id(ctx);
> - if (ret) {
> - context_close(ctx);
> - ctx = ERR_PTR(ret);
> - goto out;
> - }
> -
> - ctx->file_priv = ERR_PTR(-EBADF);
> - i915_gem_context_set_closed(ctx); /* not user accessible */
> - i915_gem_context_clear_bannable(ctx);
> - i915_gem_context_set_force_single_submission(ctx);
> - if (!USES_GUC_SUBMISSION(to_i915(dev)))
> - ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
> -
> - GEM_BUG_ON(i915_gem_context_is_kernel(ctx));
> -out:
> - mutex_unlock(&dev->struct_mutex);
> - return ctx;
> -}
> -
> static void
> destroy_kernel_context(struct i915_gem_context **ctxp)
> {
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.h b/drivers/gpu/drm/i915/gem/i915_gem_context.h
> index 106e2ccf7a4c..176978608b6f 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.h
> @@ -141,8 +141,6 @@ int i915_gem_context_open(struct drm_i915_private *i915,
> void i915_gem_context_close(struct drm_file *file);
>
> void i915_gem_context_release(struct kref *ctx_ref);
> -struct i915_gem_context *
> -i915_gem_context_create_gvt(struct drm_device *dev);
>
> int i915_gem_vm_create_ioctl(struct drm_device *dev, void *data,
> struct drm_file *file);
> diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
> index 5b29f22dc75a..a38ddb57e786 100644
> --- a/drivers/gpu/drm/i915/gvt/scheduler.c
> +++ b/drivers/gpu/drm/i915/gvt/scheduler.c
> @@ -1212,19 +1212,28 @@ i915_context_ppgtt_root_save(struct intel_vgpu_submission *s,
> */
> int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)
> {
> + struct drm_i915_private *i915 = vgpu->gvt->dev_priv;
> struct intel_vgpu_submission *s = &vgpu->submission;
> struct intel_engine_cs *engine;
> struct i915_gem_context *ctx;
> enum intel_engine_id i;
> int ret;
>
> - ctx = i915_gem_context_create_gvt(&vgpu->gvt->dev_priv->drm);
> - if (IS_ERR(ctx))
> - return PTR_ERR(ctx);
> + mutex_lock(&i915->drm.struct_mutex);
> +
> + ctx = i915_gem_context_create_kernel(i915, I915_PRIORITY_MAX);
> + if (IS_ERR(ctx)) {
> + ret = PTR_ERR(ctx);
> + goto out_unlock;
> + }
> +
> + i915_gem_context_set_force_single_submission(ctx);
> + if (!USES_GUC_SUBMISSION(i915))
> + ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
>
> i915_context_ppgtt_root_save(s, i915_vm_to_ppgtt(ctx->vm));
>
> - for_each_engine(engine, vgpu->gvt->dev_priv, i) {
> + for_each_engine(engine, i915, i) {
> struct intel_context *ce;
>
> INIT_LIST_HEAD(&s->workload_q_head[i]);
> @@ -1262,11 +1271,12 @@ int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)
> bitmap_zero(s->tlb_handle_pending, I915_NUM_ENGINES);
>
> i915_gem_context_put(ctx);
> + mutex_unlock(&i915->drm.struct_mutex);
> return 0;
>
> out_shadow_ctx:
> i915_context_ppgtt_root_restore(s, i915_vm_to_ppgtt(ctx->vm));
> - for_each_engine(engine, vgpu->gvt->dev_priv, i) {
> + for_each_engine(engine, i915, i) {
> if (IS_ERR(s->shadow[i]))
> break;
>
> @@ -1274,6 +1284,8 @@ int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)
> intel_context_put(s->shadow[i]);
> }
> i915_gem_context_put(ctx);
> +out_unlock:
> + mutex_unlock(&i915->drm.struct_mutex);
> return ret;
> }
>
> --
> 2.23.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
